Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update jQuery mousewheel from v3.1.9 to v 3.2.0 #4574

Merged
merged 10 commits into from Sep 14, 2019
Merged

Update jQuery mousewheel from v3.1.9 to v 3.2.0 #4574

merged 10 commits into from Sep 14, 2019

Conversation

ghost
Copy link

@ghost ghost commented Aug 26, 2019 •
edited by ghost
Loading

This update fixes all the deprecated jQuery code and adds several features like rate limiting for the mousewheel etc.

Link to this issue: #3867

October currently has a Google Chrome warning that says:

storm-min.js?v=455:1652 [Violation] Added non-passive event listener to a scroll-blocking 'wheel' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952

This will be fixed in jQuery v4.0.0 see here: jquery/jquery#2871

[update] jQuery team have re-opened my issue and may now consider adding a switch to turn on passive mode for event listeners. In October CMS having the event listeners turned on reduced jank issues and increase performance when I ran some tests. So it would be nice to update this pr in the near future and have the event listeners using passive mode - github issue can be found her: jquery/jquery-mousewheel#202

@ghost
Copy link
Author

ghost commented Aug 31, 2019

@bennothommo Can you please change the label on this, I would like to put a block on this pr and update it again when jQuery have fixed the passive event listener.

@ghost ghost mentioned this pull request Aug 31, 2019
Closed
@daftspunk daftspunk merged commit 2e63477 into octobercms:develop Sep 14, 2019
@daftspunk
Copy link
Member

New lib looks almost identical except for the addition of normalizeOffset option. Should be safe to merge in its current state.

@LukeTowers
Copy link
Contributor

@daftspunk it wasn't merged yet because of the following:

[update] jQuery team have re-opened my issue and may now consider adding a switch to turn on passive mode for event listeners. In October CMS having the event listeners turned on reduced jank issues and increase performance when I ran some tests. So it would be nice to update this pr in the near future and have the event listeners using passive mode - github issue can be found her: jquery/jquery-mousewheel#202

@LukeTowers LukeTowers added this to the v1.0.460 milestone Sep 14, 2019
This was referenced Sep 21, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Completed Type: Maintenance
Milestone
v1.0.460
Development

Successfully merging this pull request may close these issues.
4 participants
@daftspunk @LukeTowers @w20k @bennothommo